Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: port OSR code to new viz compositor codepath #17538
Description of Change
There is an ongoing effort to upstream a large chunk of the patch to
Notes: Fixed offscreen rendering not working with viz compositor.
referenced this pull request
Mar 27, 2019
For a pull request this large, it's challenging to inspect every nook and cranny as thoroughly as i'd like but based on this writeup and my understanding of the code at hand this seems to be sufficient for us to merge. I don't see any glaring issues and it's (imo) more important to release this to consumers such that the beta cycle surfaces any bugs that may be present therein and that weren't caught in initial development.
@nornagon Well, most of the viz osr work is actually done by Alexander Guettler, we have group PM with him, Marshall Greenblatt and @codebytere where we discussed how things are going. See https://bitbucket.org/chromiumembedded/cef/issues/2575