Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: port OSR code to new viz compositor codepath #17538
Conversation
brenca
requested a review
from electron/wg-upgrades
as a
code owner
Mar 25, 2019
electron-cation
bot
added
new-pr 🌱
and removed
new-pr 🌱
labels
Mar 25, 2019
brenca
force-pushed the
brenca/viz-osr
branch
from
cd5ec08
to
9fe2379
Mar 26, 2019
brenca
requested review from
codebytere and
zcbenz
Mar 27, 2019
brenca
changed the title
fix: port OSR code to new viz compositor codepath [WIP]
fix: port OSR code to new viz compositor codepath
Mar 27, 2019
brenca
referenced this pull request
Mar 27, 2019
Merged
fix: port OSR code to new viz compositor codepath (backport: 5-0-x) #17572
electron
deleted a comment from
trop bot
Mar 27, 2019
codebytere
reviewed
Apr 2, 2019
| @@ -0,0 +1,121 @@ | |||
| // Copyright (c) 2016 GitHub, Inc. | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
For a pull request this large, it's challenging to inspect every nook and cranny as thoroughly as i'd like but based on this writeup and my understanding of the code at hand this seems to be sufficient for us to merge. I don't see any glaring issues and it's (imo) more important to release this to consumers such that the beta cycle surfaces any bugs that may be present therein and that weren't caught in initial development. |
codebytere
approved these changes
Apr 2, 2019
sofianguy
added
the
app-feedback-program
label
Apr 3, 2019
ckerr
approved these changes
Apr 3, 2019
ckerr
added
target/5-0-x
and removed
target/5-0-x
labels
Apr 3, 2019
This comment has been minimized.
This comment has been minimized.
|
A maintainer has manually backported this PR to "5-0-x", please check out #17572 |
This comment has been minimized.
This comment has been minimized.
btw, I'm pretty sure there's only one guy from CEF: Marshall Greenblatt :) |
This comment has been minimized.
This comment has been minimized.
|
@nornagon Well, most of the viz osr work is actually done by Alexander Guettler, we have group PM with him, Marshall Greenblatt and @codebytere where we discussed how things are going. See https://bitbucket.org/chromiumembedded/cef/issues/2575 |
This comment has been minimized.
This comment has been minimized.
|
@brenca can you rebase this PR? |
brenca
and others
added some commits
Mar 20, 2019
zcbenz
and others
added some commits
Mar 22, 2019
brenca
force-pushed the
brenca/viz-osr
branch
from
19ea77b
to
d1c2b77
Apr 16, 2019
codebytere
merged commit 81bf158
into
master
Apr 17, 2019
8 checks passed
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Apr 17, 2019
|
Release Notes Persisted
|
brenca commentedMar 25, 2019
•
edited
Description of Change
Fixes #16983.
There is an ongoing effort to upstream a large chunk of the patch to
chromium(one of the guys fromCEFis doing the upstreaming, and thechromiumfolks indicated that they are open to the patch).TODO:
5-0-xChecklist
npm testpassesRelease Notes
Notes: Fixed offscreen rendering not working with viz compositor.