Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: remove native mksnapshot for arm/arm64 #17561
+65
−184
Conversation
jkleinsc
requested a review
from electron/wg-upgrades
Mar 26, 2019
This comment has been minimized.
This comment has been minimized.
|
Can we remove the patches also? |
jkleinsc
added some commits
Mar 27, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks for the reminder @nornagon. I was planning on removing them but forgot to do so. They are now removed as part of this PR. |
nornagon
approved these changes
Mar 27, 2019
This comment has been minimized.
This comment has been minimized.
|
Looks like the linux build is failing though? |
This comment has been minimized.
This comment has been minimized.
|
@nornagon I had started work on this in another branch and must have missed a commit. The latest commit should fix the linux build. |
This comment has been minimized.
This comment has been minimized.
|
Aha, I thought there ought to be more red lines! Thanks :) |
codebytere
approved these changes
Mar 27, 2019
jkleinsc
added some commits
Mar 27, 2019
This comment has been minimized.
This comment has been minimized.
|
Merging as mac failure was flake and it reran successfully here: https://circleci.com/gh/electron/electron/165267 |
jkleinsc
merged commit 7eaa57b
into
master
Mar 28, 2019
8 checks passed
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-debug
AppVeyor build succeeded
Details
appveyor: win-ia32-testing
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-debug
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Mar 28, 2019
|
Release Notes Persisted
|
jkleinsc
deleted the
remove_native_mksnapshot
branch
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jkleinsc commentedMar 26, 2019
Description of Change
Starting with Chromium 74, we can no longer build native mksnapshot binaries for arm and arm64. The decision was made by the @electron/wg-upgrades Working Group to deprecate these binaries for 5-0-x with the intention of removing them completely for 6-0-x.
This PR removes those binaries from our build and from the release. Also to make sure snapshots still work on arm/arm64, CI has been updated to create arm/arm64 snapshots using the x64 binary that are then tested on arm/arm64 hardware.
Checklist
npm testpassesRelease Notes
Notes: Removed native mksnapshot binaries for arm/arm64 as they no longer work.