Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove native mksnapshot for arm/arm64 #17561

Merged
merged 7 commits into from Mar 28, 2019

Conversation

Projects
None yet
3 participants
@jkleinsc
Copy link
Contributor

commented Mar 26, 2019

Description of Change

Starting with Chromium 74, we can no longer build native mksnapshot binaries for arm and arm64. The decision was made by the @electron/wg-upgrades Working Group to deprecate these binaries for 5-0-x with the intention of removing them completely for 6-0-x.

This PR removes those binaries from our build and from the release. Also to make sure snapshots still work on arm/arm64, CI has been updated to create arm/arm64 snapshots using the x64 binary that are then tested on arm/arm64 hardware.

Checklist

Release Notes

Notes: Removed native mksnapshot binaries for arm/arm64 as they no longer work.

@jkleinsc jkleinsc requested a review from electron/wg-upgrades Mar 26, 2019

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Can we remove the patches also?

@jkleinsc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Thanks for the reminder @nornagon. I was planning on removing them but forgot to do so. They are now removed as part of this PR.

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Looks like the linux build is failing though?

@jkleinsc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

@nornagon I had started work on this in another branch and must have missed a commit. The latest commit should fix the linux build.

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Aha, I thought there ought to be more red lines! Thanks :)

@jkleinsc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

Merging as mac failure was flake and it reran successfully here: https://circleci.com/gh/electron/electron/165267

@jkleinsc jkleinsc merged commit 7eaa57b into master Mar 28, 2019

14 of 15 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190327.35 succeeded
Details
electron-arm64-testing Build #20190327.35 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 28, 2019

Release Notes Persisted

Removed native mksnapshot binaries for arm/arm64 as they no longer work.

@jkleinsc jkleinsc deleted the remove_native_mksnapshot branch Mar 28, 2019

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

build: remove native mksnapshot for arm/arm64 (electron#17561)
* build: remove native mksnapshot for arm/arm64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.