Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default_id and cancel_id correctly on confirm dialogs (backport: 5-0-x) #17578

Conversation

Projects
None yet
1 participant
@trop
Copy link
Contributor

commented Mar 27, 2019

Backport of #17547

See that PR for details.

Notes: Fixed the handling of the escape key in dialogs created by window.confirm. The "Cancel" button is now triggered by the escape key, and the "OK" button is now triggered by the return key.

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 27, 2019

@MarshallOfSound MarshallOfSound merged commit 46841d7 into electron:5-0-x Mar 27, 2019

7 of 8 checks passed

appveyor: win-x64-testing-pr AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 27, 2019

Release Notes Persisted

Fixed the handling of the escape key in dialogs created by window.confirm. The "Cancel" button is now triggered by the escape key, and the "OK" button is now triggered by the return key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.