Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use file path as key for safeDialogs on filesystem (backport: 5-0-x) #17579

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Mar 27, 2019

Backport of #17546

See that PR for details.

Notes: The safeDialogs webPreferences option now actually works on file:// URLs

@MarshallOfSound MarshallOfSound merged commit 0e5d181 into electron:5-0-x Mar 27, 2019

8 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 27, 2019

Release Notes Persisted

The safeDialogs webPreferences option now actually works on file:// URLs

@jkleinsc jkleinsc referenced this pull request Apr 15, 2019

Closed

safeDialogs option doesn't work #17543

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.