Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add patch for framework file permissions #17582

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Copy link
Member

MarshallOfSound commented Mar 27, 2019

Description of Change

Fixes a permissions issue with the generated .framework files in 4.x

The patch is already present in 5.x and higher

Fixes #17581

Notes: Generated .framework files on macOS now have the correct permissions. This fixes an issue where a crash occurred if a user attempted to launch an Electron app that another user downloaded on macOS.

@deepak1556 deepak1556 requested a review from electron/wg-upgrades Mar 28, 2019

@MarshallOfSound MarshallOfSound merged commit b5f290d into 4-1-x Mar 28, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found

@MarshallOfSound MarshallOfSound deleted the fix-framework-permissions branch Mar 28, 2019

@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 28, 2019

Release Notes Persisted

Generated .framework files on macOS now have the correct permissions. This fixes an issue where a crash occurred if a user attempted to launch an Electron app that another user downloaded on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.