Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure dots in content script patterns aren't used as wildcards #17593

Merged
merged 4 commits into from Mar 28, 2019

Conversation

@MarshallOfSound
Copy link
Member

commented Mar 28, 2019

Notes: Injected chrome extensions that have content scripts with a . in the pattern field now treat it as a raw . instead of a wildcard

@trop

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #17594

MarshallOfSound added some commits Mar 28, 2019

@MarshallOfSound MarshallOfSound merged commit 953d1ea into master Mar 28, 2019

12 of 15 checks passed

appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing-pr Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190328.11 succeeded
Details
electron-arm64-testing Build #20190328.11 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 28, 2019

Release Notes Persisted

Injected chrome extensions that have content scripts with a . in the pattern field now treat it as a raw . instead of a wildcard

@MarshallOfSound MarshallOfSound deleted the MarshallOfSound-patch-1 branch Mar 28, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #17594

@sofianguy sofianguy added this to Fixed in 5.0.0-beta.8 in 5.0.x Apr 4, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

fix: ensure dots in content script patterns aren't used as wildcards (e…
…lectron#17593)

* fix: ensure dots in content script patterns aren't used as wildcards

* chore: sanitise all regexp special chars

* chore: extract to helper

* chore: fixup helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.