Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle a race condition between preload scripts executing and navigations (backport: 5-0-x) #17597

Conversation

Projects
None yet
1 participant
@trop
Copy link
Contributor

commented Mar 28, 2019

Backport of #17577

See that PR for details.

Notes: Fixed issue where preload scripts would sometimes run twice in the same process in different contexts resulting in broken native node module loading.

fix: handle a race condition between preload scripts executing and na…
…vigations

There is a race condition between DidCreateScriptContext and another
navigation occuring in the main process. If the navigation occurs while
the preload script is running, the same process is re-used.  This
ensures that any pending navigations are completely removed / ignored
when we trigger a new navigation.

Fixes #17576

@MarshallOfSound MarshallOfSound merged commit 9e12e8c into electron:5-0-x Mar 28, 2019

7 of 8 checks passed

Artifact Comparison
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 28, 2019

Release Notes Persisted

Fixed issue where preload scripts would sometimes run twice in the same process in different contexts resulting in broken native node module loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.