Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env variable to skip binary download on npm install #17627

Merged
merged 2 commits into from May 3, 2019

Conversation

Projects
None yet
3 participants
@jdoubleu
Copy link
Contributor

commented Mar 31, 2019

Description of Change

It adds a simple check for the environment variable ELECTRON_BINARY_SKIP_DOWNLOAD to the postinstall npm script, addressing #16071.

Checklist

Release Notes

Notes: Set the ELECTRON_SKIP_BINARY_DOWNLOAD=1 environment variable to skip electron binary download.

@jdoubleu jdoubleu requested a review from electron/wg-releases as a code owner Mar 31, 2019

@welcome

This comment has been minimized.

Copy link

commented Mar 31, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 1, 2019

Show resolved Hide resolved npm/install.js Outdated
@@ -36,6 +36,17 @@ In addition to changing the architecture, you can also specify the platform
npm install --platform=win32 electron
```

## Skip binary download

This comment has been minimized.

Copy link
@MarshallOfSound

MarshallOfSound Apr 2, 2019

Member

Can we move this after ## Cache

Show resolved Hide resolved docs/tutorial/installation.md Outdated
Show resolved Hide resolved docs/tutorial/installation.md Outdated

This can sometimes be unnecessary, e.g. in a CI environment, when testing another component.

To prevent the binary from being downloaded when you install all npm dependencies just set the environment variable `ELECTRON_BINARY_SKIP_DOWNLOAD`.

This comment has been minimized.

Copy link
@MarshallOfSound

MarshallOfSound Apr 2, 2019

Member
Suggested change
To prevent the binary from being downloaded when you install all npm dependencies just set the environment variable `ELECTRON_BINARY_SKIP_DOWNLOAD`.
To prevent the binary from being downloaded when you install all npm dependencies you can set the environment variable `ELECTRON_BINARY_SKIP_DOWNLOAD`.

jdoubleu added some commits Mar 31, 2019

@jdoubleu jdoubleu force-pushed the jdoubleu:electron-install-download-env branch from 984bdab to 7619b1a Apr 4, 2019

@jdoubleu

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

I applied all your requested changes.

@jkleinsc jkleinsc requested a review from MarshallOfSound Apr 12, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

Merging as CI failure unrelated to PR.

@jkleinsc jkleinsc merged commit a59dc56 into electron:master May 3, 2019

8 of 9 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be merged or rebased
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 3, 2019

Release Notes Persisted

Set the ELECTRON_SKIP_BINARY_DOWNLOAD=1 environment variable to skip electron binary download.

@welcome

This comment has been minimized.

Copy link

commented May 3, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

feat: add env variable to skip binary download on npm install (elect…
…ron#17627)

* feat: add env variable to skip binary download on npm install

* docs: add "Skip binary download" section to install tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.