Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat: add env variable to skip binary download on npm install #17627
Conversation
jdoubleu
requested a review
from electron/wg-releases
as a
code owner
Mar 31, 2019
electron-cation
bot
added
the
new-pr 🌱
label
Mar 31, 2019
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Mar 31, 2019
|
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
electron-cation
bot
removed
the
new-pr 🌱
label
Apr 1, 2019
MarshallOfSound
requested changes
Apr 2, 2019
npm/install.js Outdated
| @@ -36,6 +36,17 @@ In addition to changing the architecture, you can also specify the platform | |||
| npm install --platform=win32 electron | |||
| ``` | |||
|
|
|||
| ## Skip binary download | |||
This comment has been minimized.
This comment has been minimized.
docs/tutorial/installation.md Outdated
docs/tutorial/installation.md Outdated
|
|
||
| This can sometimes be unnecessary, e.g. in a CI environment, when testing another component. | ||
|
|
||
| To prevent the binary from being downloaded when you install all npm dependencies just set the environment variable `ELECTRON_BINARY_SKIP_DOWNLOAD`. |
This comment has been minimized.
This comment has been minimized.
MarshallOfSound
Apr 2, 2019
Member
| To prevent the binary from being downloaded when you install all npm dependencies just set the environment variable `ELECTRON_BINARY_SKIP_DOWNLOAD`. | |
| To prevent the binary from being downloaded when you install all npm dependencies you can set the environment variable `ELECTRON_BINARY_SKIP_DOWNLOAD`. |
jdoubleu
added some commits
Mar 31, 2019
jdoubleu
force-pushed the
jdoubleu:electron-install-download-env
branch
from
984bdab
to
7619b1a
Apr 4, 2019
This comment has been minimized.
This comment has been minimized.
|
I applied all your requested changes. |
jkleinsc
requested a review
from
MarshallOfSound
Apr 12, 2019
MarshallOfSound
approved these changes
Apr 12, 2019
MarshallOfSound
added
the
semver/minor
label
Apr 12, 2019
jkleinsc
approved these changes
May 3, 2019
This comment has been minimized.
This comment has been minimized.
|
Merging as CI failure unrelated to PR. |
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
May 3, 2019
|
Release Notes Persisted
|
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
May 3, 2019
|
Congrats on merging your first pull request! |
jdoubleu commentedMar 31, 2019
•
edited by jkleinsc
Description of Change
It adds a simple check for the environment variable
ELECTRON_BINARY_SKIP_DOWNLOADto the postinstall npm script, addressing #16071.Checklist
npm testpassesRelease Notes
Notes: Set the
ELECTRON_SKIP_BINARY_DOWNLOAD=1environment variable to skip electron binary download.