Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue 888678: Heap-use-after-free in content::KeyboardLockServiceImpl::GetKeyboardLayoutMap #17632

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
4 participants
@miniak
Copy link
Contributor

miniak commented Mar 31, 2019

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=888678
https://chromium-review.googlesource.com/c/chromium/src/+/1246290/

Destroy KeyboardLockServiceImpl instance when RenderFrameHost goes away

This CL updates KeyboardLockServiceImpl to release its mojo binding if
the RenderFrameHost instance it is linked to is destroyed.

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=888678.

/cc @electron/wg-security

@miniak miniak self-assigned this Mar 31, 2019

@miniak miniak requested a review from electron/wg-security Mar 31, 2019

@miniak miniak marked this pull request as ready for review Mar 31, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 1, 2019

@MarshallOfSound MarshallOfSound merged commit bcdc443 into 4-1-x Apr 2, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Apr 2, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=888678.

@miniak miniak deleted the miniak/keyboard-lock-service-impl-4-1-x branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.