Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue 914497: QUIC proxying breaks end-to-end encryption #17634

Merged
merged 1 commit into from Jun 3, 2019

Conversation

Projects
None yet
4 participants
@miniak
Copy link
Contributor

commented Mar 31, 2019

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914497
https://chromium.googlesource.com/chromium/src.git/+/cd92d8fb7eab1c9b5a7a99bc804718157dbe7da3

Disable the use of QUIC proxies for https:// URLs.

This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/858603

https://chromium.googlesource.com/chromium/src.git/+/4cbcbf17db00a0011b5d232617d25db0cd3bee10

Re-enable support for sending HTTPS URLs via QUIC proxies, but only when
the finch param enable_quic_proxies_for_https_urls is set.

This effectively reverts https://chromium-review.googlesource.com/c/chromium/src/+/1375112
and then fixes the underlying bug.

https://chromium.googlesource.com/chromium/src.git/+/fd2335678e96c34d14f4b20f0d9613dfbd1ccdb4

Fix a bug in network_session_configurator.cc in which support for HTTPS URLS in QUIC proxies was always set to false.

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914497.

@miniak miniak force-pushed the miniak/enable_quic_proxies_for_https_urls-4-1-x branch from eb51ec2 to 2affe62 Mar 31, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 1, 2019

@miniak miniak changed the base branch from miniak/keyboard-lock-service-impl-4-1-x to 4-1-x Apr 2, 2019

@miniak miniak force-pushed the miniak/enable_quic_proxies_for_https_urls-4-1-x branch from 2affe62 to ee0bf57 Apr 2, 2019

@miniak miniak force-pushed the miniak/enable_quic_proxies_for_https_urls-4-1-x branch from ee0bf57 to 8ec2980 May 30, 2019

@miniak miniak requested a review from electron/wg-security May 30, 2019

@miniak miniak changed the base branch from 4-1-x to 4-2-x May 30, 2019

@miniak miniak self-assigned this May 30, 2019

@miniak miniak marked this pull request as ready for review May 30, 2019

Date: Sun, 31 Mar 2019 21:12:59 +0200
Subject: =?UTF-8?q?Enable=20support=20for=20sending=20HTTPS=20URLs=20via?=
=?UTF-8?q?=20QUIC=20proxies=20only=20when=0Athe=20finch=20param=20enable?=
=?UTF-8?q?=5Fquic=5Fproxies=5Ffor=5Fhttps=5Furls=20is=20set.?=

This comment has been minimized.

Copy link
@nornagon

nornagon May 30, 2019

Contributor

that's quite a subject line

@miniak miniak removed the backport label May 31, 2019

@zcbenz

zcbenz approved these changes Jun 1, 2019

@nornagon nornagon merged commit 7976494 into 4-2-x Jun 3, 2019

11 of 13 checks passed

Valid Backport Invalid Backport
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190530.31 succeeded
Details
electron-arm64-testing Build #20190530.31 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 3, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914497.

@nornagon nornagon deleted the miniak/enable_quic_proxies_for_https_urls-4-1-x branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.