Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process.getProcessMemoryInfo not being exposed to sandbox renderers #17669

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

codebytere commented Apr 3, 2019

Description of Change

Fixes #17661.

Exposes process.getProcessMemoryInfo to sandbox renderers.

cc @MarshallOfSound

Checklist

Release Notes

Notes: Fixed process.getProcessMemoryInfo not being exposed to sandbox renderers.

@codebytere codebytere changed the title Fix proc mem info fix: process.getProcessMemoryInfo not being exposed to sandbox renderers Apr 3, 2019

@carterbs

This comment has been minimized.

Copy link

carterbs commented Apr 3, 2019

@codebytere it looks like you have an extra commit in this PR that isn't germane to #17661.

@codebytere codebytere force-pushed the fix-proc-mem-info branch from ba31a4b to f1d5b07 Apr 3, 2019

@carterbs
Copy link

carterbs left a comment

Looks good. Thanks for the quick turnaround.

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 4, 2019

@codebytere codebytere merged commit 3a0b72e into 4-1-x Apr 4, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Apr 4, 2019

Release Notes Persisted

Fixed process.getProcessMemoryInfo not being exposed to sandbox renderers.

@codebytere codebytere deleted the fix-proc-mem-info branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.