Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit process 'loaded' event in sandboxed renderers #17680

Merged
merged 1 commit into from Apr 4, 2019

Conversation

@miniak
Copy link
Contributor

commented Apr 3, 2019

Description of Change

Makes it consistent with non-sandboxed renderer behavior.

Checklist

Release Notes

Notes: Fixed 'loaded' event not being emitted in sandboxed renderers.

@ppontes

ppontes approved these changes Apr 3, 2019

@miniak miniak force-pushed the miniak/process-loaded-sandbox branch from e1b074a to 3951969 Apr 3, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 4, 2019

@MarshallOfSound MarshallOfSound merged commit 77d59e9 into master Apr 4, 2019

15 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190403.21 succeeded
Details
electron-arm64-testing Build #20190403.21 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 4, 2019

Release Notes Persisted

Process now emits 'loaded' event in sandboxed renderers.

@MarshallOfSound MarshallOfSound deleted the miniak/process-loaded-sandbox branch Apr 4, 2019

@miniak miniak changed the title feat: emit process 'loaded' event in sandboxed renderers fix: emit process 'loaded' event in sandboxed renderers Apr 16, 2019

@sofianguy sofianguy added this to Fixed in 5.0.0-beta.9 in 5.0.x Apr 20, 2019

@sofianguy sofianguy added this to Fixed (3.1.9) in 3.0.x / 3.1.x May 1, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.