Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update guide on MAS entitlements and export compliance #17695

Merged
merged 2 commits into from Apr 16, 2019

Conversation

Projects
None yet
3 participants
@samuelmeuli
Copy link
Contributor

samuelmeuli commented Apr 4, 2019

Description of Change

I updated the following information in the Mac App Store Submission Guide:

  • Fixed the value of the app groups entitlement in the parent.plist snippet – needs to be a string array instead of a string (see Apple's docs)
  • Updated the information on encryption export compliance: An ERN is apparently no longer required (see App Store Connect Help) and therefore the provided blog link is no longer relevant

Checklist

  • PR description included and stakeholders cc'd
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

samuelmeuli added some commits Apr 4, 2019

@welcome

This comment has been minimized.

Copy link

welcome bot commented Apr 4, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@MarshallOfSound
Copy link
Member

MarshallOfSound left a comment

cc @sethlu thoughts on the security groups thing? It appears to match apples docs but you know more about this than most 👍

@sethlu

This comment has been minimized.

Copy link
Member

sethlu commented Apr 5, 2019

@MarshallOfSound That the security groups are specified as an array aligns with the documentation and should work fine 😸 Also in fact, electron-osx-sign's been automatically injecting security group as an array since 2 years ago.

@MarshallOfSound
Copy link
Member

MarshallOfSound left a comment

Approving based on above 👍

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 5, 2019

@MarshallOfSound MarshallOfSound merged commit 3bf71a3 into electron:master Apr 16, 2019

3 of 4 checks passed

appveyor: win-x64-testing-pr AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Apr 16, 2019

No Release Notes

@welcome

This comment has been minimized.

Copy link

welcome bot commented Apr 16, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.