Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make name a prop on app #17701

Merged
merged 4 commits into from Apr 30, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Apr 5, 2019

Description of Change

Update app.name to be a property on app.

Checklist

Release Notes

Notes: Updated name to be a property on the app module.

@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Apr 5, 2019
@codebytere codebytere force-pushed the app-name-prop branch from 612628c to 8a17e92 Apr 19, 2019
@codebytere codebytere marked this pull request as ready for review Apr 19, 2019
@codebytere codebytere force-pushed the app-name-prop branch from 8a17e92 to d2c9860 Apr 23, 2019
@codebytere codebytere force-pushed the app-name-prop branch from d2c9860 to cd380b9 Apr 29, 2019
@codebytere codebytere requested a review from MarshallOfSound Apr 29, 2019
codebytere and others added 3 commits Apr 5, 2019
Co-Authored-By: codebytere <codebytere@github.com>
@codebytere codebytere force-pushed the app-name-prop branch from 19c0094 to fc0b0cc Apr 30, 2019
@miniak
miniak approved these changes Apr 30, 2019
@codebytere codebytere force-pushed the app-name-prop branch from fc0b0cc to 1307210 Apr 30, 2019
@codebytere

This comment has been minimized.

Copy link
Member Author

codebytere commented Apr 30, 2019

Still some win failures i'm sussing out 👇

@codebytere codebytere merged commit 8d83518 into master Apr 30, 2019
13 of 14 checks passed
13 of 14 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
Artifact Comparison Changes Detected
Details
Backportable? - 6-0-x Backport Failed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190430.30 succeeded
Details
electron-arm64-testing Build #20190430.30 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Apr 30, 2019

Release Notes Persisted

Updated name to be a property on the app module.

@codebytere codebytere deleted the app-name-prop branch Apr 30, 2019
@electron electron deleted a comment from trop bot Apr 30, 2019
Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019
Update app.name to be a property on app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.