Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ELECTRON_DEFAULT_ERROR_MODE in the GPU process #17728

Merged
merged 1 commit into from Apr 30, 2019

Conversation

@miniak
Copy link
Contributor

miniak commented Apr 8, 2019

Description of Change

It should be possible to enable Windows Error Reporting for the GPU process as well.

Checklist

Release Notes

Notes: Added missing support for ELECTRON_DEFAULT_ERROR_MODE in the GPU process

@miniak miniak requested a review from electron/wg-upgrades as a code owner Apr 8, 2019
@miniak miniak self-assigned this Apr 8, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 9, 2019
@miniak miniak force-pushed the miniak/gpu-process-error-mode branch 4 times, most recently from 9403a62 to 66ab6ef Apr 11, 2019
@miniak miniak requested a review from nornagon Apr 11, 2019
@miniak miniak force-pushed the miniak/gpu-process-error-mode branch from 66ab6ef to c30fd5a Apr 11, 2019
@miniak

This comment has been minimized.

Copy link
Contributor Author

miniak commented Apr 11, 2019

@deepak1556, @zcbenz can you have a look?

@miniak miniak force-pushed the miniak/gpu-process-error-mode branch 3 times, most recently from f82fb1b to b7afefb Apr 11, 2019
@zcbenz
zcbenz approved these changes Apr 12, 2019
Copy link
Member

nornagon left a comment

Patch LGTM, just requesting changes for the description in the patch file.

@miniak miniak force-pushed the miniak/gpu-process-error-mode branch from b7afefb to a490ef4 Apr 22, 2019
@miniak miniak requested a review from nornagon Apr 22, 2019
@miniak miniak force-pushed the miniak/gpu-process-error-mode branch 3 times, most recently from 1998af2 to 74ae759 Apr 23, 2019
@miniak miniak force-pushed the miniak/gpu-process-error-mode branch from 74ae759 to 5e09225 Apr 29, 2019
@alexeykuzmin alexeykuzmin merged commit fcf0af1 into master Apr 30, 2019
12 of 13 checks passed
12 of 13 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190429.61 succeeded
Details
electron-arm64-testing Build #20190429.61 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Apr 30, 2019

Release Notes Persisted

Added missing support for ELECTRON_DEFAULT_ERROR_MODE in the GPU process

@miniak miniak deleted the miniak/gpu-process-error-mode branch May 1, 2019
Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.