Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fix_font_thickness.patch #17737

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
5 participants
@miniak
Copy link
Contributor

commented Apr 9, 2019

Description of Change

Backport https://skia-review.googlesource.com/c/skia/+/177880, follow up to #15007

Checklist

Release Notes

Notes: Back-ported additional fix for font rendering in MacOS Mojave.

@miniak miniak self-assigned this Apr 9, 2019

@miniak miniak requested review from codebytere, nornagon and deepak1556 and removed request for codebytere Apr 9, 2019

@miniak miniak marked this pull request as ready for review Apr 9, 2019

@miniak miniak referenced this pull request Apr 9, 2019

Merged

fix: overly thin font rendering on mojave #759

4 of 4 tasks complete

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 10, 2019

@MarshallOfSound MarshallOfSound merged commit d2bff97 into 4-1-x Apr 15, 2019

14 of 15 checks passed

appveyor: win-woa-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190411.7 succeeded
Details
electron-arm64-testing Build #20190411.7 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 15, 2019

Release Notes Persisted

Back-ported additional fix for font rendering in MacOS Mojave.

@MarshallOfSound MarshallOfSound deleted the miniak/fix_font_thickness-4-1-x branch Apr 15, 2019

@dalDevelo

This comment has been minimized.

Copy link

commented Apr 25, 2019

This is not fixed in 4.1.5 😢. Screen shots below of VSCode exploration using 4.1.5, with CGFontRenderingFontSmoothingDisabled set to both YES and NO...

CGFontRenderingFontSmoothingDisabled YES

CGFontRenderingFontSmoothingDisabled NO

feint
clear

@dalDevelo dalDevelo referenced this pull request Apr 29, 2019

Merged

fix: overly thin font rendering on mojave #15007

3 of 3 tasks complete
@svipas

This comment has been minimized.

Copy link

commented May 3, 2019

@dalDevelo I tried to use the latest VS Code exploration build from here: microsoft/vscode#73119 and it was the same, I don't see any difference.

@miniak Maybe you know why the font is the same as it's in VS Code which is using Electron 4.1.5? I expected it to be a little different, but it's the same as it's with Electron 3.1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.