Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webContents 'zoom-changed' event #17747

Merged
merged 5 commits into from May 14, 2019

Conversation

Projects
None yet
5 participants
@miniak
Copy link
Contributor

commented Apr 10, 2019

Description of Change

Emit zoom-changed event when the user is trying to zoom in / out using the mouse wheel on Windows. This is the only way the Electron app will be able to handle these events when the focus is inside a (x-origin) iframe.

Checklist

Release Notes

Notes: Added zoom-changed event to webContents, which is emitted when the user is trying to zoom in / out using the mouse wheel on Windows, even if the focus is inside an (x-origin) iframe.

@miniak miniak force-pushed the miniak/zoom-changed branch from bdb4ce4 to 87f170d Apr 10, 2019

@ppontes ppontes force-pushed the miniak/zoom-changed branch from 248799f to 31c019b Apr 11, 2019

Show resolved Hide resolved spec/api-web-contents-spec.js Outdated

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 11, 2019

@ppontes ppontes force-pushed the miniak/zoom-changed branch from 31c019b to 280bdad Apr 12, 2019

@miniak miniak force-pushed the miniak/zoom-changed branch from 280bdad to 64b278c Apr 16, 2019

@miniak miniak marked this pull request as ready for review Apr 16, 2019

@miniak miniak assigned ppontes and miniak and unassigned ppontes Apr 16, 2019

@codebytere
Copy link
Member

left a comment

This needs documentation :)

@ppontes ppontes force-pushed the miniak/zoom-changed branch from 64b278c to a6e6c63 Apr 26, 2019

@miniak miniak force-pushed the miniak/zoom-changed branch from a6e6c63 to fd9700c Apr 27, 2019

@miniak miniak force-pushed the miniak/zoom-changed branch from fd9700c to 6c13cd0 May 2, 2019

@miniak miniak requested review from MarshallOfSound, ppontes and codebytere and removed request for ppontes May 2, 2019

@ppontes

ppontes approved these changes May 2, 2019

Show resolved Hide resolved spec/api-web-contents-spec.js Outdated

@miniak miniak requested a review from alexeykuzmin May 2, 2019

ppontes and others added some commits Feb 6, 2019

test: "zoom-changed" event emission from webContents when user zooms …
…with the mouse wheel.

Should only go in when Electron has webContents.sendInputContent fixed so that it properly creates
a WebMouseWheelEvent.

@miniak miniak force-pushed the miniak/zoom-changed branch from 41b522d to 9de5ae1 May 3, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

@MarshallOfSound are you ok with the current state of the PR?

@MarshallOfSound
Copy link
Member

left a comment

Still not the hugest fan of the API but better than before and I don't think given the API we're working with we can do much better

@alexeykuzmin alexeykuzmin merged commit 6609138 into master May 14, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190503.15 succeeded
Details
electron-arm64-testing Build #20190503.15 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 14, 2019

Release Notes Persisted

Added zoom-changed event to webContents, which is emitted when the user is trying to zoom in / out using the mouse wheel on Windows, even if the focus is inside an (x-origin) iframe.

@alexeykuzmin alexeykuzmin deleted the miniak/zoom-changed branch May 14, 2019

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.