Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset the NSUserNotication handle on dismiss #17796

Merged
merged 1 commit into from Apr 16, 2019

Conversation

2 participants
@MarshallOfSound
Copy link
Member

commented Apr 15, 2019

Fixes #17758

The destructor and Dismiss both attempt to removeDeliveredNotification which you can only do once.

Notes: Fix crash when manually dismissing notifications before quit on macOS

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 16, 2019

@MarshallOfSound MarshallOfSound merged commit 9c3315c into master Apr 16, 2019

18 checks passed

Artifact Comparison No Changes
Details
Backportable? - 3-1-x Clean Backport
Details
Backportable? - 4-1-x Clean Backport
Details
Backportable? - 5-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190415.3 succeeded
Details
electron-arm64-testing Build #20190415.4 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 16, 2019

Release Notes Persisted

Fix crash when manually dismissing notifications before quit on macOS

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

I have automatically backported this PR to "3-1-x", please check out #17820

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

I have automatically backported this PR to "4-1-x", please check out #17821

@trop trop bot added the in-flight/3-1-x label Apr 16, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

I have automatically backported this PR to "5-0-x", please check out #17822

@MarshallOfSound MarshallOfSound deleted the cleanup-notify branch Apr 16, 2019

@sofianguy sofianguy added this to Fixed in 5.0.0-beta.9 in 5.0.x Apr 20, 2019

@sofianguy sofianguy added this to Fixed (3.1.9) in 3.0.x / 3.1.x May 1, 2019

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.