Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy pixels in AddImageSkiaRepFromBuffer #17843

Merged
merged 1 commit into from Apr 18, 2019

Conversation

@miniak
Copy link
Contributor

commented Apr 17, 2019

Description of Change

Changing buffer data should not modify the nativeImage pixels, makes it consistent with PNG / JPEG behavior, which always copies the data.

Checklist

Release Notes

Notes: Fixed inconsistent behavior where modifying the buffer would change nativeImage pixels, while decoded PNG / JPEG data is a copy.

@miniak miniak requested a review from deepak1556 Apr 17, 2019

@zcbenz

zcbenz approved these changes Apr 18, 2019

@zcbenz zcbenz merged commit 5e7c828 into master Apr 18, 2019

18 checks passed

Artifact Comparison No Changes
Details
Backportable? - 3-1-x Clean Backport
Details
Backportable? - 4-1-x Clean Backport
Details
Backportable? - 5-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190417.15 succeeded
Details
electron-arm64-testing Build #20190417.15 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 18, 2019

Release Notes Persisted

Fixed inconsistent behavior where modifying the buffer would change nativeImage pixels, while decoded PNG / JPEG data is a copy.

@zcbenz zcbenz deleted the miniak/native-image branch Apr 18, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

I was unable to backport this PR to "4-1-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

/trop run backport-to 5-0-x

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

miniak added a commit that referenced this pull request Apr 18, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #17863

@trop trop bot added the in-flight/5-0-x label Apr 18, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

A maintainer has manually backported this PR to "4-1-x", please check out #17862

@trop trop bot added the in-flight/4-1-x label Apr 18, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

A maintainer has manually backported this PR to "3-1-x", please check out #17861

@trop trop bot added the in-flight/3-1-x label Apr 18, 2019

codebytere added a commit that referenced this pull request Apr 18, 2019

codebytere added a commit that referenced this pull request Apr 18, 2019

codebytere added a commit that referenced this pull request Apr 18, 2019

@sofianguy sofianguy added this to Fixed in 5.0.0-beta.9 in 5.0.x Apr 20, 2019

@sofianguy sofianguy added this to Fixed (3.1.9) in 3.0.x / 3.1.x May 1, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.