Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document occasional mismatch between NSImageName and string (backport: 4-1-x) #17848

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Apr 17, 2019

Backport of #17826

See that PR for details.

Notes: Documented an issue with nativeImage.createFromNamedImage where the string representations of NSImageName might not match the NSImageName.

@trop trop bot referenced this pull request Apr 17, 2019

Merged

docs: document occasional mismatch between NSImageName and string #17826

4 of 4 tasks complete

@trop trop bot added 4-2-x backport labels Apr 17, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 17, 2019

@MarshallOfSound MarshallOfSound merged commit 4175e94 into electron:4-1-x Apr 18, 2019

6 of 8 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 18, 2019

Release Notes Persisted

Documented an issue with nativeImage.createFromNamedImage where the string representations of NSImageName might not match the NSImageName.

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

/trop run backport-to 3-1-x

@trop

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-1-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

/trop run backport-to 3-1-x

@trop

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-1-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

I have automatically backported this PR to "3-1-x", please check out #17871

@trop trop bot added the in-flight/3-1-x label Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.