Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show underlying stack in errors in remote module #17851

Merged
merged 1 commit into from Apr 19, 2019

Conversation

@nornagon
Copy link
Contributor

commented Apr 18, 2019

Description of Change

When calling a remote method throws an error, the remote module returns the underlying error's message, but not the stack information, which is useful for debugging. This adds the stack info to the error message.

Checklist

Release Notes

Notes: Added additional error information to errors thrown when using the remote module.

@codebytere
Copy link
Member

left a comment

@nornagon i think this might be better as a chore perhaps?

@nornagon nornagon changed the title feat: show underlying stack in errors in remote module chore: show underlying stack in errors in remote module Apr 18, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 19, 2019

@codebytere codebytere merged commit 841e31b into master Apr 19, 2019

15 of 16 checks passed

Backportable? - 5-0-x Cancelled
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190418.1 succeeded
Details
electron-arm64-testing Build #20190418.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 19, 2019

Release Notes Persisted

Added additional error information to errors thrown when using the remote module.

@codebytere codebytere deleted the remote-error-stack branch Apr 19, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.