Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy pixels in AddImageSkiaRepFromBuffer (3-1-x) #17861

Merged
merged 1 commit into from Apr 18, 2019

Conversation

@miniak
Copy link
Contributor

commented Apr 18, 2019

Description of Change

Backport of #17843

Checklist

Release Notes

Notes: Fixed inconsistent behavior where modifying the buffer would change nativeImage pixels, while decoded PNG / JPEG data is a copy.

@miniak miniak self-assigned this Apr 18, 2019

@trop trop bot referenced this pull request Apr 18, 2019
4 of 4 tasks complete

@codebytere codebytere merged commit 276ebca into 3-1-x Apr 18, 2019

16 of 17 checks passed

appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-arm Workflow: build-arm
Details
build-arm64 Workflow: build-arm64
Details
build-ia32 Workflow: build-ia32
Details
build-mas-x64 Workflow: build-mas-x64
Details
build-osx-x64 Workflow: build-osx-x64
Details
build-x64 Workflow: build-x64
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 18, 2019

Release Notes Persisted

Fixed inconsistent behavior where modifying the buffer would change nativeImage pixels, while decoded PNG / JPEG data is a copy.

@codebytere codebytere deleted the miniak/native-image-3-1-x branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.