Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drain tasks before shutting down isolate (master) #17879

Merged
merged 1 commit into from Apr 19, 2019

Conversation

@zcbenz
Copy link
Member

commented Apr 19, 2019

Description of Change

Fix a possible crash on exit, see #17877 for more details

Checklist

Release Notes

Notes: Fix a possible crash on exit

@zcbenz zcbenz referenced this pull request Apr 19, 2019

Merged

fix: drain tasks before shutting down isolate (5-0-x) #17877

4 of 4 tasks complete
@codebytere
Copy link
Member

left a comment

lgtm

@nitsakh
Copy link
Contributor

left a comment

LGTM! 👍

@brenca brenca self-requested a review Apr 19, 2019

@brenca

brenca approved these changes Apr 19, 2019

Copy link
Member

left a comment

lgtm too :D

@codebytere codebytere merged commit 3441970 into master Apr 19, 2019

15 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190419.8 succeeded
Details
electron-arm64-testing Build #20190419.10 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 19, 2019

Release Notes Persisted

Fixed a possible crash on exit on Windows

@codebytere codebytere deleted the drain-tasks branch Apr 19, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.