Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated app.enableMixedSandbox() #17894

Merged
merged 1 commit into from Apr 24, 2019

Conversation

@miniak
Copy link
Contributor

miniak commented Apr 21, 2019

Description of Change

Follow up to #15894

Checklist

Release Notes

Notes: Removed deprecated app.enableMixedSandbox() API.

/cc @nornagon

@miniak miniak requested a review from nornagon Apr 21, 2019
@miniak miniak force-pushed the miniak/remove-mixed-sandbox-api branch 3 times, most recently from 3633464 to d1a3078 Apr 21, 2019
@miniak miniak self-assigned this Apr 22, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 22, 2019
@miniak miniak added the target/6-1-x label Apr 22, 2019
Copy link
Member

codebytere left a comment

I'd say we should document the option to disable it entirely with in docs/api/chrome-command-line-switches.md. This looks g2g once that's done tho!

@miniak miniak force-pushed the miniak/remove-mixed-sandbox-api branch from d1a3078 to 36b03fc Apr 23, 2019
@miniak miniak requested a review from codebytere Apr 23, 2019
@codebytere codebytere merged commit 253d049 into master Apr 24, 2019
14 of 15 checks passed
14 of 15 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190423.39 succeeded
Details
electron-arm64-testing Build #20190423.40 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Apr 24, 2019

Release Notes Persisted

Removed deprecated app.enableMixedSandbox() API.

@codebytere codebytere deleted the miniak/remove-mixed-sandbox-api branch Apr 24, 2019
Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.