Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow embedder overriding of internal FS calls #17906

Merged
merged 1 commit into from Apr 22, 2019

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Copy link
Member

commented Apr 22, 2019

Fixes #17893

Matches electron/node@a86a4a1

Notes: Fixed loading of node_modules inside ASAR files

@MarshallOfSound MarshallOfSound force-pushed the fix-asar-internal-fs branch from de95001 to fb661d6 Apr 22, 2019

@MarshallOfSound MarshallOfSound merged commit d15bcfb into 5-0-x Apr 22, 2019

12 of 15 checks passed

Valid Backport Invalid Backport
Details
appveyor: win-x64-debug Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190422.15 succeeded
Details
electron-arm64-testing Build #20190422.15 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 22, 2019

Release Notes Persisted

Fixed loading of node_modules inside ASAR files

@MarshallOfSound MarshallOfSound deleted the fix-asar-internal-fs branch Apr 22, 2019

codebytere added a commit that referenced this pull request May 6, 2019

adill added a commit to discordapp/electron that referenced this pull request May 6, 2019

jkleinsc added a commit that referenced this pull request May 7, 2019

trop bot pushed a commit that referenced this pull request May 7, 2019

codebytere added a commit that referenced this pull request May 7, 2019

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.