Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove promisification deprecation callbacks #17907

Merged
merged 9 commits into from Apr 30, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Apr 23, 2019

Description of Change

Remove promisification deprecations and tests verifying callback versions. I think i got everything but please let me know if i missed any of them!

cc @miniak @MarshallOfSound

Checklist

Release Notes

Notes: Removed deprecations for asynchronous functions to force use of promises.

@codebytere codebytere requested review from miniak and MarshallOfSound Apr 23, 2019
@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Apr 23, 2019
docs/api/session.md Outdated Show resolved Hide resolved
@miniak
miniak approved these changes Apr 24, 2019
Copy link
Contributor

miniak left a comment

approved by mistake

@codebytere codebytere force-pushed the bye-bye-cbs branch 2 times, most recently from 9f20402 to ca177d3 Apr 24, 2019
@codebytere codebytere requested a review from miniak Apr 24, 2019
@codebytere codebytere force-pushed the bye-bye-cbs branch 6 times, most recently from 629b8e6 to 7f57b6c Apr 25, 2019
@miniak miniak force-pushed the bye-bye-cbs branch from 7f57b6c to c2b1a1f Apr 29, 2019
@miniak
miniak approved these changes Apr 29, 2019
@jkleinsc jkleinsc merged commit d87b3ea into master Apr 30, 2019
12 of 13 checks passed
12 of 13 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190429.52 succeeded
Details
electron-arm64-testing Build #20190429.51 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Apr 30, 2019

Release Notes Persisted

Removed deprecations for asynchronous functions to force use of promises.

@jkleinsc jkleinsc deleted the bye-bye-cbs branch Apr 30, 2019
Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019
* chore: remove promisification deprecation callbacks

* update docs

* fix smoke test

* fix executejs issue

* cleanup leftovers

* fix webContents.executeJavaScript tests

* cleanup WebContents.prototype.takeHeapSnapshot

* fix "sets arbitrary webContents as devtools" test

* fix executeJavaScriptInFrame related tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.