Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when run from SMB network share #17908

Conversation

Projects
None yet
1 participant
@trop
Copy link
Contributor

commented Apr 23, 2019

Backport of #17886

See that PR for details.

Notes: Fixed crash when Electron run from SMB network share.

@trop trop bot referenced this pull request Apr 23, 2019

Merged

fix: crash when run from SMB network share #17886

4 of 4 tasks complete

@trop trop bot added 5-0-x backport labels Apr 23, 2019

@codebytere
Copy link
Member

left a comment

@electron/wg-releases let's hold this one for 5.0.1

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 23, 2019

@codebytere
Copy link
Member

left a comment

v5.0.0 has been released!

@codebytere codebytere merged commit f3a05c3 into 5-0-x Apr 24, 2019

14 of 15 checks passed

Valid Backport Invalid Backport
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190423.7 succeeded
Details
electron-arm64-testing Build #20190423.6 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 24, 2019

Release Notes Persisted

Fixed crash when Electron run from SMB network share.

@codebytere codebytere deleted the trop/5-0-x-bp-fix-crash-when-run-from-smb-network-share-1555986548867 branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.