Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use IPC helpers in window-setup #17948

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
3 participants
@miniak
Copy link
Contributor

commented Apr 24, 2019

Description of Change

Use ipcRendererUtils.invoke(Sync) / ipcMainUtils.handle to eliminate duplicate code and properly propagate errors to the caller side.

We need to handle loadURL similar to #18990

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak force-pushed the miniak/guest-window-manager branch 3 times, most recently from 59c4ea4 to 5310baf Apr 24, 2019

@miniak miniak self-assigned this Apr 24, 2019

@miniak miniak force-pushed the miniak/guest-window-manager branch 3 times, most recently from 26b0578 to 26988ce Apr 24, 2019

@miniak miniak added the wip label Apr 25, 2019

@miniak miniak force-pushed the miniak/guest-window-manager branch from 26988ce to e25e784 Apr 25, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 25, 2019

@miniak miniak force-pushed the miniak/guest-window-manager branch 3 times, most recently from 26ae333 to 092f727 May 9, 2019

@miniak miniak referenced this pull request May 9, 2019

Merged

refactor: add invoke helpers to window-setup #18233

3 of 3 tasks complete

@miniak miniak force-pushed the miniak/guest-window-manager branch from 092f727 to 5ebfa8f May 19, 2019

@miniak miniak force-pushed the miniak/guest-window-manager branch from 5ebfa8f to f17d5ba Jun 20, 2019

@miniak miniak force-pushed the miniak/guest-window-manager branch 4 times, most recently from bda10be to 9ed2c83 Jul 2, 2019

@miniak miniak changed the title refactor: use IPC helpers in guest-window-manager / window-setup refactor: use IPC helpers in window-setup Jul 5, 2019

@miniak miniak force-pushed the miniak/guest-window-manager branch 2 times, most recently from d96ea01 to c0d8cc6 Jul 5, 2019

@miniak miniak requested review from zcbenz and nornagon Jul 5, 2019

@miniak miniak marked this pull request as ready for review Jul 5, 2019

@miniak miniak removed the wip label Jul 5, 2019

@miniak miniak requested a review from codebytere Jul 5, 2019

@miniak miniak force-pushed the miniak/guest-window-manager branch from c0d8cc6 to 058b386 Jul 7, 2019

@miniak miniak force-pushed the miniak/guest-window-manager branch from 058b386 to 870dafc Jul 8, 2019

@alexeykuzmin alexeykuzmin merged commit 419ce49 into master Jul 8, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190708.21 succeeded
Details
electron-arm64-testing Build #20190708.21 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 8, 2019

No Release Notes

@alexeykuzmin alexeykuzmin deleted the miniak/guest-window-manager branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.