Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upchore: rename atom-binding-setup.ts to electron-binding-setup.ts #17949
+8
−8
Conversation
miniak
requested a review
from
codebytere
Apr 24, 2019
electron-cation
bot
added
the
new-pr 🌱
label
Apr 24, 2019
codebytere
approved these changes
Apr 24, 2019
ckerr
approved these changes
Apr 24, 2019
miniak
self-assigned this
Apr 25, 2019
alexeykuzmin
approved these changes
Apr 25, 2019
electron-cation
bot
removed
the
new-pr 🌱
label
Apr 25, 2019
miniak
force-pushed the
miniak/electron-binding-setup
branch
from
a230d98
to
9120b41
Apr 26, 2019
miniak
force-pushed the
miniak/electron-binding-setup
branch
from
9120b41
to
ed5041f
Apr 27, 2019
alexeykuzmin
added
target/6-0-x
and removed
target/6-0-x
labels
Apr 29, 2019
This comment has been minimized.
This comment has been minimized.
|
Tests failures on some platforms are not related to the change. Merged. |
alexeykuzmin
merged commit 18b77a4
into
master
Apr 29, 2019
7 of 8 checks passed
appveyor: win-ia32-testing
AppVeyor build failed
Details
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-debug
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-debug
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Apr 29, 2019
|
No Release Notes |
alexeykuzmin
deleted the
miniak/electron-binding-setup
branch
Apr 29, 2019
This comment has been minimized.
This comment has been minimized.
|
@miniak Can you please backport the change manually to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
miniak commentedApr 24, 2019
•
edited
Description of Change
Follow up to #17419
Checklist
npm testpassesRelease Notes
Notes: no-notes
/cc @codebytere