Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ensure consistent lock files across multiple machines #17955

Merged
merged 5 commits into from Apr 30, 2019

Conversation

Projects
None yet
4 participants
@MarshallOfSound
Copy link
Member

commented Apr 24, 2019

Uses npx yarn instead of npm to fix inconsistent lock files

Notes: no-notes

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

tests failing? with

../src/main.cc:1:10: fatal error: js_native_api.h: No such file or directory

@MarshallOfSound MarshallOfSound changed the title build: ensure consistent package-lock across multiple machines build: ensure consistent lock files across multiple machines Apr 29, 2019

@MarshallOfSound

This comment has been minimized.

Copy link
Member Author

commented Apr 29, 2019

This is the commit that does the npm->yarn conversion.

f00066f

@MarshallOfSound

This comment has been minimized.

Copy link
Member Author

commented Apr 29, 2019

As an added bonus --frozen-lockfile will cause CI to fail if the package.json doesn't match the current lock file.

@codebytere
Copy link
Member

left a comment

i wish we didn’t need to use yarn but given mitigating circumstances
i think it’s unfortunately what we must do

@MarshallOfSound MarshallOfSound merged commit 98c51dd into master Apr 30, 2019

11 of 14 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Artifact Comparison Changes Detected
Details
Backportable? - 6-0-x Backport Failed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190429.59 succeeded
Details
electron-arm64-testing Build #20190429.59 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 30, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the npx branch Apr 30, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/6-0-x and removed target/6-0-x labels Apr 30, 2019

MarshallOfSound added a commit that referenced this pull request Apr 30, 2019

build: ensure consistent lock files across multiple machines (#17955)
* build: ensure consistent package-lock across multiple machines

* build: fix linting errors and use npm ci instead of npm install

* build: use a yarn.lock and yarn instead of package-lock and npm

* chore: replace package-lock.json files with yarn.lock

* chore: replace last instance of `npm install`
@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #18071

@trop trop bot added the in-flight/6-0-x label Apr 30, 2019

MarshallOfSound added a commit that referenced this pull request Apr 30, 2019

build: ensure consistent lock files across multiple machines (#17955)
* build: ensure consistent package-lock across multiple machines

* build: fix linting errors and use npm ci instead of npm install

* build: use a yarn.lock and yarn instead of package-lock and npm

* chore: replace package-lock.json files with yarn.lock

* chore: replace last instance of `npm install`

MarshallOfSound added a commit that referenced this pull request Apr 30, 2019

build: ensure consistent lock files across multiple machines (#17955)
* build: ensure consistent package-lock across multiple machines

* build: fix linting errors and use npm ci instead of npm install

* build: use a yarn.lock and yarn instead of package-lock and npm

* chore: replace package-lock.json files with yarn.lock

* chore: replace last instance of `npm install`

MarshallOfSound added a commit that referenced this pull request May 1, 2019

build: ensure consistent lock files across multiple machines (#17955) (
…#18071)

* build: ensure consistent package-lock across multiple machines

* build: fix linting errors and use npm ci instead of npm install

* build: use a yarn.lock and yarn instead of package-lock and npm

* chore: replace package-lock.json files with yarn.lock

* chore: replace last instance of `npm install`

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

build: ensure consistent lock files across multiple machines (electro…
…n#17955)

* build: ensure consistent package-lock across multiple machines

* build: fix linting errors and use npm ci instead of npm install

* build: use a yarn.lock and yarn instead of package-lock and npm

* chore: replace package-lock.json files with yarn.lock

* chore: replace last instance of `npm install`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.