Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign uprefactor: session.clearAuthCache nws13n #17970
+11
−88
Conversation
nornagon
requested a review
from
deepak1556
Apr 25, 2019
electron-cation
bot
added
new-pr 🌱
and removed
new-pr 🌱
labels
Apr 25, 2019
deepak1556
approved these changes
May 1, 2019
nornagon
added
the
wip ⚒
label
May 1, 2019
This comment has been minimized.
This comment has been minimized.
|
Do not merge yet, I want to understand if it's actually OK to remove these APIs. (& land the deprecation first.) |
nornagon
referenced this pull request
May 2, 2019
Open
chore: deprecate the 'options' argument to clearAuthCache #18131
This comment has been minimized.
This comment has been minimized.
|
Landing this because we're going to have to figure out some way of moving this function to the network service before 7-0-x lands, so if we need to do more to support pre-existing use cases, we can build on top of this change :) |
nornagon
removed
the
wip ⚒
label
May 3, 2019
nornagon
merged commit cb13d7a
into
master
May 3, 2019
7 of 8 checks passed
appveyor: win-ia32-testing
AppVeyor build failed
Details
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-debug
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-debug
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
May 3, 2019
|
Release Notes Persisted
|
nornagon
deleted the
nws13n-clear-auth-cache
branch
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nornagon commentedApr 25, 2019
Description of Change
Refactor session.clearAuthCache to use the network service. This results in losing the ability to filter what is cleared; we should deprecate this in 6-0-x.
Checklist
npm testpassesRelease Notes
Notes: session.clearAuthCache no longer allows filtering the cleared cache entries.