Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: session.clearAuthCache nws13n #17970

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
2 participants
@nornagon
Copy link
Contributor

commented Apr 25, 2019

Description of Change

Refactor session.clearAuthCache to use the network service. This results in losing the ability to filter what is cleared; we should deprecate this in 6-0-x.

Checklist

Release Notes

Notes: session.clearAuthCache no longer allows filtering the cleared cache entries.

@nornagon nornagon requested a review from deepak1556 Apr 25, 2019

@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Apr 25, 2019

@nornagon nornagon added the wip label May 1, 2019

@nornagon

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Do not merge yet, I want to understand if it's actually OK to remove these APIs. (& land the deprecation first.)

@nornagon

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

Landing this because we're going to have to figure out some way of moving this function to the network service before 7-0-x lands, so if we need to do more to support pre-existing use cases, we can build on top of this change :)

@nornagon nornagon removed the wip label May 3, 2019

@nornagon nornagon merged commit cb13d7a into master May 3, 2019

7 of 8 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 3, 2019

Release Notes Persisted

session.clearAuthCache no longer allows filtering the cleared cache entries.

@nornagon nornagon deleted the nws13n-clear-auth-cache branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.