Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when failed to get devices in desktopCapturer #17973

Conversation

@trop
Copy link
Contributor

commented Apr 25, 2019

Backport of #17557

See that PR for details.

Notes: Fixed a crash when failed to get devices in desktopCapturer on Windows.

@trop trop bot referenced this pull request Apr 25, 2019

Merged

fix: crash when failed to get devices in desktopCapturer #17557

4 of 4 tasks complete

@trop trop bot added 6-0-x backport labels Apr 25, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 25, 2019

@codebytere codebytere merged commit 7226ad1 into 6-0-x Apr 26, 2019

15 of 16 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190425.23 succeeded
Details
electron-arm64-testing Build #20190425.23 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 26, 2019

Release Notes Persisted

Fixed a crash when failed to get devices in desktopCapturer on Windows.

@codebytere codebytere deleted the trop/6-0-x-bp-fix-crash-when-failed-to-get-devices-in-desktopcapturer-1556230373203 branch Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.