Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add patch to partially revert chromium crashpad change #17978

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
3 participants
@nitsakh
Copy link
Contributor

commented Apr 25, 2019

Description of Change

This adds a patch to support functionality that we were using but chromium changed it. Electron uses breakpad on windows, chromium uses crashpad (which is newer). So this patch is needed until we update electron to use crashpad for windows.

Checklist

Release Notes

Notes: no-notes

chore: Add patch to partially revert chromium crashpad change
This adds a patch to support functionality that we were using but chromium changed it. Electron uses breakpad on windows, chromium uses crashpad (which is newer). So this patch is needed until we update electron to use crashpad for windows.

@nitsakh nitsakh requested a review from electron/wg-upgrades as a code owner Apr 25, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 26, 2019

@codebytere

This comment has been minimized.

Copy link
Member

commented May 1, 2019

@nitsakh can you update the patch conflict?

@nornagon
Copy link
Contributor

left a comment

Patch looks OK, but what's the path going forward? We can't float this patch forever :\

@nitsakh

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

@nornagon I'm working on #17993, which should be the path going forward.

@trop

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #18198

@trop trop bot added the in-flight/6-0-x label May 7, 2019

@electron electron deleted a comment from trop bot May 7, 2019

@nitsakh nitsakh merged commit 85c24c0 into master May 10, 2019

13 of 14 checks passed

Backportable? - 6-0-x Cancelled
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190507.20 succeeded
Details
electron-arm64-testing Build #20190507.20 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 10, 2019

No Release Notes

@codebytere codebytere deleted the restore-crashpad-win branch May 10, 2019

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

chore: Add patch to partially revert chromium crashpad change (electr…
…on#17978)

This adds a patch to support functionality that we were using but chromium changed it. Electron uses breakpad on windows, chromium uses crashpad (which is newer). So this patch is needed until we update electron to use crashpad for windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.