Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: notify MC of failures to allow easy reruns #17981

Merged
merged 1 commit into from Apr 26, 2019

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Copy link
Member

commented Apr 26, 2019

This posts failed build notifications to Mission Control so that it can then forward failed build notifications to the appropriate Slack users who can then click "re-run" from within slack.

This is part 1 of a "let people rerun builds from slack" wave of things. Screenshots included below.

Notification
image

After ReRun
image

Notes: no-notes

@MarshallOfSound MarshallOfSound merged commit d673865 into master Apr 26, 2019

13 of 15 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
build-linux Workflow: build-linux
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190426.5 succeeded
Details
electron-arm64-testing Build #20190426.5 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 26, 2019

No Release Notes

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.