Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat: allow setting of global fallback user agent #18016
+63
−5
Conversation
electron-cation
bot
added
the
new-pr 🌱
label
Apr 28, 2019
MarshallOfSound
added
the
target/6-0-x
label
Apr 28, 2019
This comment has been minimized.
This comment has been minimized.
|
Put this on the @electron/wg-releases agenda to discuss |
electron-cation
bot
removed
the
new-pr 🌱
label
Apr 29, 2019
codebytere
reviewed
Apr 29, 2019
|
It'd be awesome if this was set as a property on the prototype instead :) |
MarshallOfSound
force-pushed the
feat/set-user-agent-globally
branch
from
0a13c3c
to
e50aa19
Apr 30, 2019
This comment has been minimized.
This comment has been minimized.
lint death |
MarshallOfSound
force-pushed the
feat/set-user-agent-globally
branch
from
e50aa19
to
05fea02
Apr 30, 2019
codebytere
approved these changes
May 1, 2019
|
lgtm but i'd love a second review before we merge this. |
codebytere
added
the
semver/minor
label
May 1, 2019
MarshallOfSound
merged commit d4f5ebe
into
master
May 1, 2019
5 of 6 checks passed
appveyor: win-ia32-testing
AppVeyor build failed
Details
Semantic Pull Request
ready to be merged or rebased
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
MarshallOfSound
deleted the
feat/set-user-agent-globally
branch
May 1, 2019
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
May 1, 2019
•
|
Release Notes Persisted
|
This comment has been minimized.
This comment has been minimized.
|
I was unable to backport this PR to "6-0-x" cleanly; |
trop
bot
added
needs-manual-bp/6-0-x
and removed
target/6-0-x
labels
May 1, 2019
MarshallOfSound
referenced this pull request
May 2, 2019
Merged
feat: allow setting of global fallback user agent #18110
This comment has been minimized.
This comment has been minimized.
|
A maintainer has manually backported this PR to "4-2-x", please check out #18110 |
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
A maintainer has manually backported this PR to "4-2-x", please check out #18110 |
trop
bot
added
the
in-flight/4-2-x
label
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
MarshallOfSound commentedApr 28, 2019
•
edited by miniak
Currently we support letting apps set user agents on
webContentsandsessionbut not "for everything". Well this PR allows you to do just that. In particular it allows apps to do a few thingsNotes: Added new
app.userAgentFallbackproperty to allow setting the apps useragent globally