Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable Vulkan validation layers #18060

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

commented Apr 30, 2019

Backport of #17985

See that PR for details.

Notes: Removed Vulkan validation layers DLLs from electron.zip, which are only meant to be used for Chromium development.

@trop trop bot referenced this pull request Apr 30, 2019

Merged

build: disable Vulkan validation layers #17985

4 of 4 tasks complete

@trop trop bot added 4-2-x backport labels Apr 30, 2019

@codebytere codebytere merged commit f65a798 into 4-1-x May 1, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190430.18 succeeded
Details
electron-arm64-testing Build #20190430.18 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 1, 2019

Release Notes Persisted

Removed Vulkan validation layers DLLs from electron.zip, which are only meant to be used for Chromium development.

@codebytere codebytere deleted the trop/4-1-x-bp-build-disable-vulkan-validation-layers-1556631732272 branch May 1, 2019

@miniak miniak referenced this pull request May 4, 2019

Closed

Update to Electron v4.2.0 #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.