Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure the inspector agent is shutdown before cleaning up the node env #18076

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Apr 30, 2019

Backport of #18028

See that PR for details.

Notes: Fixed crash when quitting Electron with an inspector attached

@jkleinsc jkleinsc merged commit 1154f3c into 5-0-x May 1, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190430.50 succeeded
Details
electron-arm64-testing Build #20190430.52 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 1, 2019

Release Notes Persisted

Fixed crash when quitting Electron with an inspector attached

@jkleinsc jkleinsc deleted the trop/5-0-x-bp-fix-ensure-the-inspector-agent-is-shutdown-before-cleaning-up-the-node-env-1556664296880 branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.