Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly focus window on win.show() #18079

Conversation

Projects
None yet
1 participant
@trop
Copy link
Contributor

commented Apr 30, 2019

Backport of #18046

See that PR for details.

Notes: Fixed an issue on Windows where calling .show() on a BrowserWindow did not focus the window.

@trop trop bot referenced this pull request Apr 30, 2019

Merged

fix: explicitly focus window on win.show() #18046

4 of 4 tasks complete

@trop trop bot added 4-2-x backport labels Apr 30, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 30, 2019

@codebytere codebytere merged commit d1f5d20 into 4-1-x May 1, 2019

12 of 13 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190501.3 succeeded
Details
electron-arm64-testing Build #20190501.2 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 1, 2019

Release Notes Persisted

Fixed an issue on Windows where calling .show() on a BrowserWindow did not focus the window.

@codebytere codebytere deleted the trop/4-1-x-bp-fix-explicitly-focus-window-on-win-show--1556667844055 branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.