Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retry octokit calls several times on fail #18085

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented May 1, 2019

Description of Change

Retry any of the octokit requests in the notes generator 3 times before actually failing the script.

cc @MarshallOfSound

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from MarshallOfSound May 1, 2019

@codebytere codebytere force-pushed the retry-octokit branch from e0e3913 to 387816c May 1, 2019

@jkleinsc
Copy link
Contributor

left a comment

I could be wrong, but I think the retry logic here won't play nicely with the async functions.

Show resolved Hide resolved script/release-notes/notes.js Outdated
Show resolved Hide resolved script/release-notes/notes.js Outdated

@codebytere codebytere force-pushed the retry-octokit branch 2 times, most recently from 0d55352 to d3bdd1c May 1, 2019

Show resolved Hide resolved script/release-notes/notes.js Outdated
Show resolved Hide resolved script/release-notes/notes.js Outdated
Show resolved Hide resolved script/release-notes/notes.js Outdated

@codebytere codebytere requested review from jkleinsc and MarshallOfSound May 1, 2019

@codebytere codebytere requested a review from MarshallOfSound May 1, 2019

@jkleinsc
Copy link
Contributor

left a comment

Looks like lint is failing with:

/home/builduser/project/src/electron/script/release-notes/notes.js
  322:12  error  Redundant use of `await` on a return value  no-return-await
  333:12  error  Redundant use of `await` on a return value  no-return-await
Show resolved Hide resolved script/release-notes/notes.js Outdated
Show resolved Hide resolved script/release-notes/notes.js Outdated

@codebytere codebytere force-pushed the retry-octokit branch from be55e3f to 072f20a May 1, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label May 2, 2019

@codebytere codebytere requested a review from jkleinsc May 2, 2019

@codebytere codebytere merged commit c278043 into master May 2, 2019

5 of 6 checks passed

appveyor: win-x64-testing AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 2, 2019

No Release Notes

@codebytere codebytere deleted the retry-octokit branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.