Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upchore: retry octokit calls several times on fail #18085
+29
−20
Conversation
electron-cation
bot
added
the
new-pr 🌱
label
May 1, 2019
codebytere
requested a review
from
MarshallOfSound
May 1, 2019
codebytere
force-pushed the
retry-octokit
branch
from
e0e3913
to
387816c
May 1, 2019
jkleinsc
requested changes
May 1, 2019
|
I could be wrong, but I think the retry logic here won't play nicely with the async functions. |
script/release-notes/notes.js Outdated
script/release-notes/notes.js Outdated
codebytere
force-pushed the
retry-octokit
branch
2 times, most recently
from
0d55352
to
d3bdd1c
May 1, 2019
MarshallOfSound
requested changes
May 1, 2019
script/release-notes/notes.js Outdated
script/release-notes/notes.js Outdated
script/release-notes/notes.js Outdated
codebytere
requested review from
jkleinsc and
MarshallOfSound
May 1, 2019
MarshallOfSound
reviewed
May 1, 2019
script/release-notes/notes.js Outdated
MarshallOfSound
reviewed
May 1, 2019
script/release-notes/notes.js Outdated
codebytere
requested a review
from
MarshallOfSound
May 1, 2019
jkleinsc
requested changes
May 1, 2019
|
Looks like lint is failing with:
|
script/release-notes/notes.js Outdated
script/release-notes/notes.js Outdated
codebytere
force-pushed the
retry-octokit
branch
from
be55e3f
to
072f20a
May 1, 2019
electron-cation
bot
removed
the
new-pr 🌱
label
May 2, 2019
codebytere
requested a review
from
jkleinsc
May 2, 2019
jkleinsc
approved these changes
May 2, 2019
MarshallOfSound
approved these changes
May 2, 2019
codebytere
merged commit c278043
into
master
May 2, 2019
5 of 6 checks passed
appveyor: win-x64-testing
AppVeyor build failed
Details
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-testing
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
May 2, 2019
|
No Release Notes |
codebytere
deleted the
retry-octokit
branch
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
codebytere commentedMay 1, 2019
Description of Change
Retry any of the octokit requests in the notes generator 3 times before actually failing the script.
cc @MarshallOfSound
Checklist
Release Notes
Notes: none