Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly parse default_app path on windows #18086

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Copy link
Member

commented May 1, 2019

Noticed this on my Windows machine while verifying the 6.0.0-beta.1 release. On windows, pathname looks like /c:/a/b/c (that preceding / breaks things). No notes as it's a default_app UI change, app devs don't need to know.

This is the bug -->
image

Notes: no-notes

@miniak
Copy link
Contributor

left a comment

what about doing a similar check to how we enforce preload scripts to be from the appPath?
https://github.com/electron/electron/blob/master/lib/browser/rpc-server.js#L514

@miniak

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@MarshallOfSound maybe related to #18092

@MarshallOfSound

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

@miniak The issue here isn't asar or realpath. We can't call realpath on the result of URL().pathname as URL does not return a valid Windows path. It is very much UNIX style.

@MarshallOfSound MarshallOfSound merged commit 913bd4c into master May 1, 2019

13 of 14 checks passed

electron-arm-testing Build #20190501.15 had test failures
Details
Artifact Comparison No Changes
Details
Backportable? - 6-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190501.14 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 1, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the fix-def-app-win branch May 1, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

I have automatically backported this PR to "6-0-x", please check out #18102

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.