Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: correctly parse default_app path on windows #18086
+5
−1
Conversation
MarshallOfSound
added
the
target/6-0-x
label
May 1, 2019
electron-cation
bot
added
the
new-pr 🌱
label
May 1, 2019
miniak
reviewed
May 1, 2019
|
what about doing a similar check to how we enforce preload scripts to be from the appPath? |
This comment has been minimized.
This comment has been minimized.
|
@MarshallOfSound maybe related to #18092 |
This comment has been minimized.
This comment has been minimized.
|
@miniak The issue here isn't asar or realpath. We can't call |
codebytere
approved these changes
May 1, 2019
MarshallOfSound
merged commit 913bd4c
into
master
May 1, 2019
6 checks passed
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-testing
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
May 1, 2019
|
No Release Notes |
MarshallOfSound
deleted the
fix-def-app-win
branch
May 1, 2019
trop
bot
referenced this pull request
May 1, 2019
Merged
fix: correctly parse default_app path on windows #18102
This comment has been minimized.
This comment has been minimized.
|
I have automatically backported this PR to "6-0-x", please check out #18102 |
trop
bot
added
in-flight/6-0-x
merged/6-0-x
and removed
target/6-0-x
labels
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
MarshallOfSound commentedMay 1, 2019
Noticed this on my Windows machine while verifying the
6.0.0-beta.1release. On windows,pathnamelooks like/c:/a/b/c(that preceding/breaks things). No notes as it's adefault_appUI change, app devs don't need to know.This is the bug -->
Notes: no-notes