Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow stream protocols to return headers with multiple values #18094

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
3 participants
@miniak
Copy link
Contributor

commented May 1, 2019

Description of Change

Backport of #14887

Checklist

Release Notes

Notes: Fixed returning headers with multiple values for stream protocols.

fix: allow stream protocols to return headers with multiple values (#…
…14887)

* fix: allow stream protocols to return headers with multiple values

This allows stream protocols to return headers with multiple values as
an array of values.

Fixes #14778

* Prefer ConvertFromV8

* Cleanup header conversion

1. Deduplicate the code by using a lambda
2. Remove duplicate calls to headers->Get(key)

* Fix broken test

Headers with multiple values are now being converted correctly, this
test asserted the wrong behavior.

@MarshallOfSound MarshallOfSound merged commit ac714a1 into 4-1-x May 1, 2019

12 of 13 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190501.36 succeeded
Details
electron-arm64-testing Build #20190501.37 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 1, 2019

Release Notes Persisted

Fixed returning headers with multiple values for stream protocols.

@MarshallOfSound MarshallOfSound deleted the miniak/fix-header-conversion-4-1-x branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.