Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add native_mate to lint:cpp #18100

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
5 participants
@miniak
Copy link
Contributor

commented May 1, 2019

Description of Change

Adds native_mate to lint:cpp and fixes all issues found. Follow up to #18088.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak requested review from zcbenz and deepak1556 May 1, 2019

Show resolved Hide resolved script/lint.js

@miniak miniak self-assigned this May 1, 2019

@miniak miniak force-pushed the miniak/lint-native-mate branch from 8346130 to 71f1702 May 1, 2019

@nornagon
Copy link
Contributor

left a comment

We should consider removing one of the native_mate directories; now that we're fully GN-based there's no need to have native_mate/native_mate.

Show resolved Hide resolved atom/browser/api/atom_api_content_tracing.cc Outdated
@codebytere

This comment has been minimized.

Copy link
Member

commented May 1, 2019

@nornagon the subdirectorying was originally done to preserve history; it may be removable now but i'm not sure! cc @MarshallOfSound

@miniak miniak force-pushed the miniak/lint-native-mate branch from 71f1702 to 2cbafff May 1, 2019

@zcbenz

zcbenz approved these changes May 2, 2019

@zcbenz zcbenz merged commit 8785e90 into master May 2, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190501.91 succeeded
Details
electron-arm64-testing Build #20190501.90 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 2, 2019

No Release Notes

@zcbenz zcbenz deleted the miniak/lint-native-mate branch May 2, 2019

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.