Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upchore: add native_mate to lint:cpp #18100
+147
−136
Conversation
miniak
requested review from
zcbenz and
deepak1556
May 1, 2019
electron-cation
bot
added
the
new-pr 🌱
label
May 1, 2019
deepak1556
approved these changes
May 1, 2019
miniak
self-assigned this
May 1, 2019
miniak
force-pushed the
miniak/lint-native-mate
branch
from
8346130
to
71f1702
May 1, 2019
nornagon
approved these changes
May 1, 2019
|
We should consider removing one of the |
This comment has been minimized.
This comment has been minimized.
|
@nornagon the subdirectorying was originally done to preserve history; it may be removable now but i'm not sure! cc @MarshallOfSound |
codebytere
approved these changes
May 1, 2019
miniak
force-pushed the
miniak/lint-native-mate
branch
from
71f1702
to
2cbafff
May 1, 2019
zcbenz
approved these changes
May 2, 2019
zcbenz
merged commit 8785e90
into
master
May 2, 2019
6 checks passed
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-testing
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
May 2, 2019
|
No Release Notes |
zcbenz
deleted the
miniak/lint-native-mate
branch
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
miniak commentedMay 1, 2019
•
edited
Description of Change
Adds
native_matetolint:cppand fixes all issues found. Follow up to #18088.Checklist
npm testpassesRelease Notes
Notes: no-notes