Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upchore: add clang-format and limited linting for Objective-C sources #18104
+142
−36
Conversation
electron-cation
bot
added
the
new-pr 🌱
label
May 1, 2019
miniak
self-assigned this
May 1, 2019
miniak
force-pushed the
miniak/lint-objc
branch
from
e9151a8
to
738b447
May 1, 2019
miniak
requested review from
nornagon,
codebytere and
deepak1556
May 1, 2019
This comment has been minimized.
This comment has been minimized.
|
@zcbenz can you have a look, please? |
miniak
requested a review
from
zcbenz
May 2, 2019
alexeykuzmin
approved these changes
May 2, 2019
zcbenz
approved these changes
May 2, 2019
zcbenz
merged commit 9585818
into
master
May 2, 2019
6 checks passed
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-testing
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
May 2, 2019
|
No Release Notes |
zcbenz
deleted the
miniak/lint-objc
branch
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
miniak commentedMay 1, 2019
Description of Change
Add clang-format and limited linting for Objective-C sources
Checklist
npm testpassesRelease Notes
Notes: no-notes