Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: do not mark navigations interupted with same-document navigations as aborted #18109
+28
−1
Conversation
MarshallOfSound
requested a review
from
nornagon
May 1, 2019
electron-cation
bot
added
the
new-pr 🌱
label
May 1, 2019
deepak1556
approved these changes
May 1, 2019
This comment has been minimized.
This comment has been minimized.
|
Can you add a spec based on the issue sample. Thanks! |
This comment has been minimized.
This comment has been minimized.
vladimiry
commented
May 2, 2019
|
Also please consider making |
nornagon
approved these changes
May 2, 2019
electron-cation
bot
removed
the
new-pr 🌱
label
May 2, 2019
MarshallOfSound
added some commits
May 1, 2019
MarshallOfSound
force-pushed the
do-not-abort-virtual-routing
branch
from
dbc93e6
to
91e6985
May 3, 2019
MarshallOfSound
added
target/5-0-x
target/6-0-x
labels
May 3, 2019
MarshallOfSound
merged commit 636273b
into
master
May 3, 2019
6 checks passed
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-testing
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
May 3, 2019
|
Release Notes Persisted
|
MarshallOfSound
deleted the
do-not-abort-virtual-routing
branch
May 3, 2019
trop
bot
referenced this pull request
May 3, 2019
Merged
fix: do not mark navigations interupted with same-document navigations as aborted #18142
This comment has been minimized.
This comment has been minimized.
|
I have automatically backported this PR to "5-0-x", please check out #18142 |
trop
bot
referenced this pull request
May 3, 2019
Merged
fix: do not mark navigations interupted with same-document navigations as aborted #18143
This comment has been minimized.
This comment has been minimized.
|
I have automatically backported this PR to "6-0-x", please check out #18143 |
trop
bot
added
in-flight/5-0-x
in-flight/6-0-x
merged/6-0-x
merged/5-0-x
and removed
target/5-0-x
target/6-0-x
labels
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
MarshallOfSound commentedMay 1, 2019
Fixes #17526
This is probably the closest thing we can get to something that makes everyone happy. Virtual navigations are now ignored, actually interrupting the
loadURLcall with anotherloadURLcall still correctly rejects the first promise.Notes: Fixed case where the promise returned by
loadURLandloadFilewould be rejected withERR_ABORTEDif you triggered a virtual navigation before the page had finished loading. E.g. Usedhistory.pushStateor setlocation.hash