fix: do not mark navigations interupted with same-document navigations as aborted #18109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
approved these changes
May 1, 2019
|
Can you add a spec based on the issue sample. Thanks! |
|
Also please consider making |
nornagon
approved these changes
May 2, 2019
MarshallOfSound
force-pushed
the
do-not-abort-virtual-routing
branch
from
dbc93e6
to
91e6985
Compare
|
Release Notes Persisted
|
|
I have automatically backported this PR to "5-0-x", please check out #18142 |
|
I have automatically backported this PR to "6-0-x", please check out #18143 |
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
…s as aborted (electron#18109) * fix: do not mark navigations interupted with same-document navigations as aborted * spec: add tests for the loadURL promise
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17526
This is probably the closest thing we can get to something that makes everyone happy. Virtual navigations are now ignored, actually interrupting the
loadURLcall with anotherloadURLcall still correctly rejects the first promise.Notes: Fixed case where the promise returned by
loadURLandloadFilewould be rejected withERR_ABORTEDif you triggered a virtual navigation before the page had finished loading. E.g. Usedhistory.pushStateor setlocation.hash