Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upchore: convert more files away from base::Bind #18121
+86
−71
Conversation
electron-cation
bot
added
the
new-pr 🌱
label
May 2, 2019
deepak1556
approved these changes
May 2, 2019
electron-cation
bot
removed
the
new-pr 🌱
label
May 3, 2019
jkleinsc
approved these changes
May 3, 2019
jkleinsc
merged commit 0755857
into
master
May 3, 2019
6 checks passed
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-testing
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
May 3, 2019
|
No Release Notes |
jkleinsc
deleted the
more-bind
branch
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
codebytere commentedMay 2, 2019
•
edited
Description of Change
Continuation of
base::Bindconversion efforts.Checklist
npm testpassesRelease Notes
Notes: none