Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert more files away from base::Bind #18121

Merged
merged 2 commits into from May 3, 2019

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented May 2, 2019

Description of Change

Continuation of base::Bind conversion efforts.

Checklist

Release Notes

Notes: none

Show resolved Hide resolved atom/browser/net/url_request_buffer_job.cc Outdated

@electron-cation electron-cation bot removed the new-pr 🌱 label May 3, 2019

@jkleinsc jkleinsc merged commit 0755857 into master May 3, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190503.20 succeeded
Details
electron-arm64-testing Build #20190503.20 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 3, 2019

No Release Notes

@jkleinsc jkleinsc deleted the more-bind branch May 3, 2019

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

chore: convert more files away from base::Bind (electron#18121)
* chore: convert more files away from base::Bind

* use BindOnce for JsAsker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.