Skip to content

/electron

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove v8 reverts now that nan is updated #18130

Merged
merged 1 commit into from May 3, 2019
+39 −1,605

Conversation

Reviewers

@nornagon nornagon

Assignees
No one assigned
Labels
new-pr 🌱
Projects
None yet
Milestone
No milestone
2 participants
@MarshallOfSound @nornagon
@MarshallOfSound
Copy link
Member

commented May 2, 2019

Now that nan has removed it's dependencies on some of these deprecated V8 APIs we can remove the patches we had that reverted their removal.

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from electron/wg-upgrades as a code owner May 2, 2019

@electron-cation electron-cation bot added the new-pr 🌱 label May 2, 2019

@MarshallOfSound MarshallOfSound requested a review from nornagon May 2, 2019

@nornagon

nornagon approved these changes May 2, 2019
View changes

@MarshallOfSound MarshallOfSound merged commit 99d4537 into master May 3, 2019
5 of 6 checks passed

5 of 6 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Sign in to view
Copy link

commented May 3, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the remove-v8-reverts branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.