Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate the 'options' argument to clearAuthCache #18131

Merged
merged 3 commits into from May 7, 2019

Conversation

@nornagon
Copy link
Contributor

commented May 2, 2019

Description of Change

The network service APIs do not support the fine-grained clearing of the auth cache. In preparation for switching to the network service in 7.x, log a warning that the options argument is deprecated. Ref #17970.

This might not be quite right as we could also potentially expose the new options that are available: namely, start and end time. #17970 does not expose those options, but it would in theory be possible to support them with the existing network service APIs. The current options object does not offer time-based cache clearing.

Checklist

Release Notes

Notes: Deprecated the options argument to session.clearAuthCache.

@nornagon nornagon requested a review from deepak1556 May 2, 2019

nornagon added some commits May 3, 2019

@codebytere codebytere merged commit 5b7bd56 into 6-0-x May 7, 2019

11 of 15 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
electron-arm-testing Build #20190503.34 had test failures
Details
Artifact Comparison Changes Detected
Details
Backportable? - 6-0-x Cancelled
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190503.37 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 7, 2019

Release Notes Persisted

Deprecated the options argument to session.clearAuthCache.

@codebytere codebytere deleted the clearauthcache-deprecation branch May 7, 2019

@sofianguy sofianguy added this to Fixed in 6.0.0-beta.2 in 6.0.x May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.