Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not mark navigations interupted with same-document navigations as aborted #18142

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

commented May 3, 2019

Backport of #18109

See that PR for details.

Notes: Fixed case where the promise returned by loadURL and loadFile would be rejected with ERR_ABORTED if you triggered a virtual navigation before the page had finished loading. E.g. Used history.pushState or set location.hash

@electron-cation electron-cation bot removed the new-pr 🌱 label May 3, 2019

@codebytere codebytere merged commit 82bb6d4 into 5-0-x May 4, 2019

12 of 13 checks passed

electron-arm-testing Build #20190503.42 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190503.46 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 4, 2019

Release Notes Persisted

Fixed case where the promise returned by loadURL and loadFile would be rejected with ERR_ABORTED if you triggered a virtual navigation before the page had finished loading. E.g. Used history.pushState or set location.hash

@codebytere codebytere deleted the trop/5-0-x-bp-fix-do-not-mark-navigations-interupted-with-same-document-navigations-as-aborted-1556925611039 branch May 4, 2019

@miniak

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

@codebytere this PR introduced a linter error due to unused variable:

npm run lint

> electron@5.0.3 lint /Volumes/Builds/github/electron-5.0/src/electron
> node ./script/lint.js && npm run lint:clang-format && npm run lint:docs


/Volumes/Builds/github/electron-5.0/src/electron/spec/api-browser-window-spec.js
  309:13  error  'data' is assigned a value but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)

can you please fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.