Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated APIs #18159

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
4 participants
@miniak
Copy link
Contributor

commented May 4, 2019

Description of Change

BREAKING CHANGE

The following deprecated APIs are supposed to be removed in Electron 7:

  • powerMonitor.querySystemIdleState()
  • powerMonitor.querySystemIdleTime()
  • webFrame.setIsolatedWorldContentSecurityPolicy()
  • webFrame.setIsolatedWorldHumanReadableName()
  • webFrame.setIsolatedWorldSecurityOrigin()
  • app.getApplicationMenu()
  • app.setApplicationMenu()

Checklist

Release Notes

Notes: Removed deprecated APIs: powerMonitor.querySystemIdleState(), powerMonitor.querySystemIdleTime(), webFrame.setIsolatedWorldContentSecurityPolicy(), webFrame.setIsolatedWorldHumanReadableName(), webFrame.setIsolatedWorldSecurityOrigin(), app.getApplicationMenu() and app.setApplicationMenu().

@miniak miniak marked this pull request as ready for review May 4, 2019

@miniak miniak self-assigned this May 4, 2019

@miniak miniak requested review from codebytere and nitsakh May 4, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label May 5, 2019

@codebytere
Copy link
Member

left a comment

Please add these to the Planned Breaking Changes document

@nornagon

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

Also add BREAKING CHANGE to the PR body

@miniak miniak force-pushed the miniak/remove-deprecated-apis branch from 08a0e16 to a8dbe12 May 6, 2019

@miniak miniak requested a review from codebytere May 6, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

@codebytere should I also mention app.getApplicationMenu() / app.setApplicationMenu()?, those APIs have not been documented.

Show resolved Hide resolved docs/api/breaking-changes.md Outdated

@miniak miniak force-pushed the miniak/remove-deprecated-apis branch from a8dbe12 to e8644b8 May 8, 2019

@miniak miniak requested a review from codebytere May 8, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

@miniak can you rebase this?

@miniak miniak force-pushed the miniak/remove-deprecated-apis branch from e8644b8 to 0c4c182 May 9, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

@jkleinsc done

@jkleinsc jkleinsc merged commit 019b31d into master May 9, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190509.13 succeeded
Details
electron-arm64-testing Build #20190509.13 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 9, 2019

Release Notes Persisted

Removed deprecated APIs: powerMonitor.querySystemIdleState(), powerMonitor.querySystemIdleTime(), webFrame.setIsolatedWorldContentSecurityPolicy(), webFrame.setIsolatedWorldHumanReadableName(), webFrame.setIsolatedWorldSecurityOrigin(), app.getApplicationMenu() and app.setApplicationMenu().

@jkleinsc jkleinsc deleted the miniak/remove-deprecated-apis branch May 9, 2019

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.