Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove last instances of base::Bind #18178

Merged
merged 4 commits into from May 29, 2019

Conversation

Projects
None yet
4 participants
@codebytere
Copy link
Member

commented May 6, 2019

Description of Change

Remove last instances of base::Bind in favor of base::BindOnce and base::BindRepeating.

cc @zcbenz @deepak1556

Checklist

Release Notes

Notes: none

@deepak1556
Copy link
Member

left a comment

Mostly LGTM

Show resolved Hide resolved atom/browser/atom_browser_client.cc Outdated
Show resolved Hide resolved atom/browser/common_web_contents_delegate.cc
Show resolved Hide resolved atom/browser/osr/osr_render_widget_host_view.cc

@electron-cation electron-cation bot removed the new-pr 🌱 label May 7, 2019

codebytere added some commits May 6, 2019

@codebytere codebytere force-pushed the last-bind branch from 6721f90 to bbc62c5 May 28, 2019

@codebytere codebytere requested review from deepak1556 and nornagon May 28, 2019

@zcbenz

zcbenz approved these changes May 29, 2019

@codebytere codebytere merged commit 9af5072 into master May 29, 2019

12 of 13 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190529.11 succeeded
Details
electron-arm64-testing Build #20190529.11 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 29, 2019

No Release Notes

@codebytere codebytere deleted the last-bind branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.